Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wave 3 Bank Accounts #67

Open
wants to merge 27 commits into
base: jln/master
Choose a base branch
from
Open

Wave 3 Bank Accounts #67

wants to merge 27 commits into from

Commits on Oct 8, 2015

  1. Add wave 3

    @kariabancroft
    kariabancroft committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    b79bdfe View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into jln/master

    @noglows
    noglows committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    8814190 View commit details
    Browse the repository at this point in the history

  3. Made a new bank.rb file that requires all the different account types

    @noglows
    noglows committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    8edeb3f View commit details
    Browse the repository at this point in the history

  4. Broke the accounts into different files

    @noglows
    noglows committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    c364b4f View commit details
    Browse the repository at this point in the history

  5. Updated old bank.rb file - this will be deleted later

    @noglows
    noglows committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    622f68c View commit details
    Browse the repository at this point in the history

  6. Updated fee to a float

    @noglows
    noglows committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    f851166 View commit details
    Browse the repository at this point in the history

  7. Updated withdraw logic so that edge cases are handled

    @noglows
    noglows committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    73915bb View commit details
    Browse the repository at this point in the history

  8. Initial working checking account

    @noglows
    noglows committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    a04961a View commit details
    Browse the repository at this point in the history

  9. Added the reset checks method

    @noglows
    noglows committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    715cb38 View commit details
    Browse the repository at this point in the history

  10. Added money_market_account and modified account withdraw method to ac… 

    …comodate money_market_acct
    @noglows
    noglows committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    b789fb0 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2015

  1. Fixed some money market issues

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    2406a37 View commit details
    Browse the repository at this point in the history

  2. Fixed bug in withdraw method and added add_interest method to parent … 

    …class
    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    cbb30ef View commit details
    Browse the repository at this point in the history

  3. Fixed bugs in money market account

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    aaa58fb View commit details
    Browse the repository at this point in the history

  4. Modified checking and savings account to take dollars as input instea… 

    …d of cents
    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    8b98e5a View commit details
    Browse the repository at this point in the history

  5. Cleaning up files

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    06832af View commit details
    Browse the repository at this point in the history

  6. Cleaning up file names

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    6a7a92d View commit details
    Browse the repository at this point in the history

  7. Created retired files folder

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    c021e14 View commit details
    Browse the repository at this point in the history

  8. All outputs to the user round to two decimal places

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    7d83da6 View commit details
    Browse the repository at this point in the history

  9. Fixed more rounding errors

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    35448bd View commit details
    Browse the repository at this point in the history

  10. Added comments to Money Market

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    92ba7b1 View commit details
    Browse the repository at this point in the history

  11. Added comments to checking account

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    50509e6 View commit details
    Browse the repository at this point in the history

  12. Added comments to savings account

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    0073289 View commit details
    Browse the repository at this point in the history

  13. Comment to bank.rb file

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    f418c1f View commit details
    Browse the repository at this point in the history

  14. Removed the to-do.txt file

    @noglows
    noglows committed Oct 9, 2015
    Configuration menu
    Copy the full SHA
    3ee8881 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2015

  1. Finished comment and fixed money market bug

    @noglows
    noglows committed Oct 12, 2015
    Configuration menu
    Copy the full SHA
    b10b425 View commit details
    Browse the repository at this point in the history

  2. Fixed Money Market withdrawal bug

    @noglows
    noglows committed Oct 12, 2015
    Configuration menu
    Copy the full SHA
    e2ef83e View commit details
    Browse the repository at this point in the history

  3. Removed owner require from Account

    @noglows
    noglows committed Oct 12, 2015
    Configuration menu
    Copy the full SHA
    76268ff View commit details
    Browse the repository at this point in the history