Removed storyStoreV7 and babelModeV7 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandilling-adaptive
requested review from
tprince232,
Honglin-Lu,
wenfeng-xing and
EdAdaptive
Honglin-Lu
approved these changes
Nov 9, 2022
EdAdaptive
approved these changes
Nov 9, 2022
tprince232
approved these changes
Nov 9, 2022
|
Great find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the V7 features seems to fix both of these issues. I added these before we moved to a monorepo to fix an issue with Storybooks manager having issues importing our other TS files into storybook's TS config files, but now that we import from the JS build files, it should be safe to remove them.
Fixes #128
Fixes #127