Skip to content

Commit

Permalink
Fixed github actions recommendations and removed redundant files
Browse files Browse the repository at this point in the history
  • Loading branch information
Robert-SD committed Aug 15, 2023
1 parent 40d96b1 commit 6adb0e8
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 16 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/check_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,8 @@ jobs:
channel: 'stable'
- run: flutter --version

# Note: This workflow uses the latest stable version of the Dart SDK.
# You can specify other versions if desired, see documentation here:
# https://github.com/dart-lang/setup-dart/blob/main/README.md
# - uses: dart-lang/setup-dart@v1
- uses: dart-lang/setup-dart@9a04e6d73cca37bd455e0608d7e5092f881fd603

- name: Install dependencies
run: dart pub get
run: flutter pub get

# Uncomment this step to verify the use of 'dart format' on each commit.
# - name: Verify formatting
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/scripts/setup.sh

This file was deleted.

1 change: 0 additions & 1 deletion .github/workflows/scripts/test.sh

This file was deleted.

4 changes: 2 additions & 2 deletions example/integration_test/plugin_integration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ void main() {

testWidgets('getPlatformVersion test', (WidgetTester tester) async {
final AdyenCheckout plugin = AdyenCheckout();
final String? version = await plugin.getPlatformVersion();
final String version = await plugin.getPlatformVersion();
// The version string depends on the host platform running the test, so
// just assert that some non-empty string is returned.
expect(version?.isNotEmpty, true);
expect(version.isNotEmpty, true);
});
}
3 changes: 1 addition & 2 deletions example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ class _MyAppState extends State<MyApp> {
// Platform messages may fail, so we use a try/catch PlatformException.
// We also handle the message potentially returning null.
try {
platformVersion = await _adyenCheckout.getPlatformVersion() ??
'Unknown platform version';
platformVersion = await _adyenCheckout.getPlatformVersion();
} on PlatformException {
platformVersion = 'Failed to get platform version.';
}
Expand Down

0 comments on commit 6adb0e8

Please sign in to comment.