Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more tests for CLI commands. #70

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Gitstar-OC
Copy link

This PR

  • Adds more tests in the tests/test_cli_loads.py folder to test the other commands
  • Updates the contributing file and adds testing part in it instead of ## Tests HAHAHAHAHAHAHA good one

@Gitstar-OC
Copy link
Author

As asked in #7

@Gitstar-OC Gitstar-OC mentioned this pull request Nov 28, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
@bboynton97
Copy link
Contributor

hi @Gitstar-OC! thank you for the contribution!

in the future when opening a pull request, be sure to merge from a branch other than main even on your fork. it allows the maintainers to easily add to your contribution and help get a PR past the finish line :)

since i can't push to this branch, i'm including my changes as notes in the review. if you can commit these, i'll ask @tcdent to review again (since my work is in this PR now) and merge

tests/test_cli_loads.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bboynton97 bboynton97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@Gitstar-OC
Copy link
Author

Gitstar-OC commented Nov 30, 2024

Hey sorry for the problems caused I will solve them and also will use a new branch from the next time.

@bboynton97
Copy link
Contributor

one more edit required. be sure to run tox to test locally and ensure it works

@Gitstar-OC
Copy link
Author

All of the things are completed, also ran the tests. Sorry that you faced some problems becuase I did not create a new branch will create a new one for other issues, could I get to work a little bit on frontend if that's possible ?

image

Tests were successful

@Gitstar-OC
Copy link
Author

I don't understand why are this workflows failing ? They are working if I run the tests in the development mode and failing in production.

I will check the error and fix them don't worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants