Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3174): hover for whole group #3201

Merged
merged 7 commits into from
May 6, 2024
Merged

feat(#3174): hover for whole group #3201

merged 7 commits into from
May 6, 2024

Conversation

haug1
Copy link
Contributor

@haug1 haug1 commented May 3, 2024

Adds hover targeting for the whole group.

image

Not a great gif to demonstrate the fix, but without the patch, there's a transparent background instead of black.

#power {
  background-color: transparent;
  color: white;
}

#power *:hover {
  background-color: white;
  color: black;
}

#power:hover {
  background-color: black;
  color: white;
}
  "group/power": {
    "orientation": "inherit",
    "drawer": {
      "transition-duration": 500,
      "children-class": "not-power",
      "transition-left-to-right": false,
    },
    "modules": [
      "custom/lock",
      "custom/quit",
      "custom/suspend",
      "custom/reboot",
    ],
  },
      widget:dir(ltr)
        box#power.horizontal:dir(ltr)
          revealer.drawer:dir(ltr)
            box.horizontal:dir(ltr)
              widget.not-power:dir(ltr)
                label#custom-quit.module:dir(ltr)
              widget.not-power:dir(ltr)
                label#custom-suspend.module:dir(ltr)
              widget.not-power:dir(ltr)
                label#custom-reboot.module:dir(ltr)
          widget:dir(ltr)
            label#custom-lock.module:dir(ltr)

@haug1
Copy link
Contributor Author

haug1 commented May 3, 2024

Good to go, I think.

@haug1
Copy link
Contributor Author

haug1 commented May 5, 2024

Well, in hindsight of course that's not going to help as a hacky workaround because security reasons.. Last commit should obviously be reverted, but I don't dare to touch anything more for now in case I trigger more CI that gets stuck infinitely..
Really hoping that will hit some sort of timeout soon..

@haug1
Copy link
Contributor Author

haug1 commented May 5, 2024

Okay, I tried one more thing in hopes of stopping the workflow by making it fail the linting task, but seems it never gets that far before it gets stuck. Sorry..! Again, last commit should be reverted..

@Alexays Alexays merged commit e7779b5 into Alexays:master May 6, 2024
7 of 9 checks passed
@haug1 haug1 deleted the feat/hover-on-whole-group branch May 6, 2024 09:04
zjeffer pushed a commit to zjeffer/Waybar that referenced this pull request May 7, 2024
* feat(Alexays#3174): hover for whole group

* fix: target eventbox for class also

* fix: actually no reason to add handler, just override AModule

* fix: actually remove existing handler as well

drawer functionality still works from my testing. anything else to think
abotu?

* revert: keep id and class on original box

* refactor: clang-format group.hpp

* dev: try stop workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants