-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
添加leaderElection,支持多副本高可用部署 #63
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 52.58% 52.58%
=======================================
Files 24 24
Lines 1434 1434
=======================================
Hits 754 754
Misses 618 618
Partials 62 62 Continue to review full report at Codecov.
|
That's really cool! |
I will review this pr later. |
This pr is too large because of vendor changes. Could you split this PR into two commit. One is for the source code changes and the other for the vendor. Thanks! |
Resubmitted |
@silenceper 你这个实现,对副本数有要求吗?比如要奇数个不能偶数个之类的 然后就是,主从节点怎么消费 Event 的 |
还有,如果你要配置高可用的话,YAML 文件必须用反亲和度让所有的pod不运行在同一个节点吧? |
没要求,跟你理解的etcd不一样,它实现是一个分布式锁,谁先抢占到就执行,其余的等待,同时工作的只会有一个节点 |
那可以以 |
可以 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 52.58% 53.24% +0.66%
==========================================
Files 24 24
Lines 1434 1448 +14
==========================================
+ Hits 754 771 +17
+ Misses 618 614 -4
- Partials 62 63 +1 ☔ View full report in Codecov by Sentry. |
fix #62