Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proc macro feature. #11

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

daxpedda
Copy link

@daxpedda daxpedda commented Jun 8, 2020

Implement proc macro alternative to rusty_fork_test!.
Theres a bit of documentation missing and maybe more unit tests could help, I'm willing to do it, but would like some direction.

Fixes #9.

Blocked on #10.

[dependencies]
fnv = "1.0"
quick-error = "1.2"
rusty-fork-macro = { path = "rusty-fork-macro", optional = true }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this even be optional?

rusty-fork-macro/Cargo.toml Outdated Show resolved Hide resolved
rusty-fork-macro/Cargo.toml Outdated Show resolved Hide resolved
rusty-fork-macro/Cargo.toml Outdated Show resolved Hide resolved
rusty-fork-macro/src/lib.rs Outdated Show resolved Hide resolved
rusty-fork-macro/src/lib.rs Outdated Show resolved Hide resolved
@debnil
Copy link

debnil commented Mar 31, 2021

@daxpedda: I'd like to use rust-fork to test an async function using tokio, and this PR looks perfect for that.

Are there any plans to merge this? If you need additional community help to finish this, I'm happy to contribute.

@daxpedda
Copy link
Author

daxpedda commented Apr 1, 2021

I will take a look at it, if anybody who his responsible for the project can answer some of my questions above that would be splendid.
The PR is done, my questions above, except documentation, are purely organizational, but otherwise the PR is ready to be merged.

@daxpedda
Copy link
Author

daxpedda commented Apr 1, 2021

So looking through hit again, I realized that this PR is not as clean as I would like it.
It tries to solve two problems at once, that is implement a proc macro, and return a Result. I think this PR would be better served if #10 would be merged first.
#10 is already finished and ready to be merged as far as I am concerned.

@daxpedda daxpedda marked this pull request as draft April 1, 2021 09:51
@daxpedda daxpedda force-pushed the proc-macro-feature branch from 8541b1c to 5a8e54f Compare April 1, 2021 10:42
@daxpedda
Copy link
Author

daxpedda commented Apr 1, 2021

I cleaned everything up now:

This is now only blocked on #10, which again, is ready to be merged as far as I am concerned.

@debnil
Copy link

debnil commented Apr 1, 2021

Wow - thanks so much for the fast turnaround and excellent work!

@AltSysrq: this pull request, along with #10, would extend support for async tests. Merging both would be incredibly helpful. Thank you so much for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for async tests
2 participants