-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#235: Can't execute background process on remote server #239
base: master
Are you sure you want to change the base?
Conversation
@t-cas @re-schneider Hi all, any ETA on when this PR might be merged to resolve #235? |
@wherka-ama: Could you please split your PR in 2:
|
jumpssh/session.py
Outdated
@@ -222,7 +223,8 @@ def run_cmd( | |||
success_exit_code=0, | |||
retry=0, | |||
retry_interval=5, | |||
keep_retry_history=False | |||
keep_retry_history=False, | |||
get_pty=False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For backward compatibility purpose, the default value for get_pty should be True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this change is fully backward compatible you should not even have to updates the tests with new flag, could you revert your changes in the test file to confirm the backward compatibility ?
Done. It's ready for another go. Thanks for your time @t-cas ! |
No description provided.