Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#235: Can't execute background process on remote server #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wherka-ama
Copy link

No description provided.

@wherka-ama wherka-ama linked an issue Feb 4, 2022 that may be closed by this pull request
@bradhvr
Copy link

bradhvr commented Jun 2, 2022

@t-cas @re-schneider Hi all, any ETA on when this PR might be merged to resolve #235?

@t-cas
Copy link
Contributor

t-cas commented Jun 6, 2022

@wherka-ama: Could you please split your PR in 2:

@@ -222,7 +223,8 @@ def run_cmd(
success_exit_code=0,
retry=0,
retry_interval=5,
keep_retry_history=False
keep_retry_history=False,
get_pty=False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For backward compatibility purpose, the default value for get_pty should be True

@wherka-ama wherka-ama changed the title Can't execute background process on remote server #235 and a couple of things around GitHub Actions Can't execute background process on remote server #235 Jun 27, 2022
@wherka-ama wherka-ama changed the title Can't execute background process on remote server #235 Issue#235: Can't execute background process on remote server Jun 27, 2022
@wherka-ama
Copy link
Author

wherka-ama commented Jun 27, 2022

@t-cas : I've changed the existing PR in order to focus on the Issue #235 for now. It is a rather simple change and pretty safe to merge. The second part which used to be bundled in(GH Actions etd.) will be a bit more complex. I'll push another PR for that in a bit.

Copy link
Contributor

@t-cas t-cas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this change is fully backward compatible you should not even have to updates the tests with new flag, could you revert your changes in the test file to confirm the backward compatibility ?

@wherka-ama
Copy link
Author

as this change is fully backward compatible you should not even have to updates the tests with new flag, could you revert your changes in the test file to confirm the backward compatibility ?

Done. It's ready for another go. Thanks for your time @t-cas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't execute background process on remote server
3 participants