Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the tsconfig spec generated for library contains several issues #2584

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cpaulve-1A
Copy link
Contributor

Proposed change

Align with application generation and reuse angular tsconfig.spec.json

Related issues

@cpaulve-1A cpaulve-1A requested a review from a team as a code owner December 12, 2024 14:58
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.53%. Comparing base (5cb8aeb) to head (84d3dfd).
Report is 37 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../@o3r/workspace/schematics/library/rules/shared.ts 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an it-test https://github.com/AmadeusITGroup/otter/blob/main/packages/%40o3r/workspace/schematics/index.it.spec.ts#L117 to make sure the test are working on the generated lib?

fpaul-1A
fpaul-1A previously approved these changes Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The tsconfig spec generated for library contains several issues
3 participants