Merge pull request #25 from Amphiluke/issue-24

Revise widget removal from the DOM
Amphiluke · Jan 18, 2024 · 4575125 · 4575125
2 parents a31c7bb + 5cf60b3
commit 4575125
Show file tree

Hide file tree

Showing 7 changed files with 138 additions and 120 deletions.
diff --git a/dist/handy-scroll.es6.js b/dist/handy-scroll.es6.js
@@ -1,5 +1,5 @@
 /*!
-handy-scroll v1.1.4
+handy-scroll v1.1.5
 https://amphiluke.github.io/handy-scroll/
 (c) 2024 Amphiluke
 */
@@ -189,7 +189,7 @@ https://amphiluke.github.io/handy-scroll/
             instance.eventHandlers.forEach(({el, handlers}) => {
                 Object.keys(handlers).forEach(event => el.removeEventListener(event, handlers[event], false));
             });
-            instance.widget.parentNode.removeChild(instance.widget);
+            instance.widget.remove();
             instance.eventHandlers = instance.widget = instance.container = instance.scrollBody = null;
         }
     };

diff --git a/dist/handy-scroll.es6.min.js b/dist/handy-scroll.es6.min.js
diff --git a/dist/handy-scroll.js b/dist/handy-scroll.js
@@ -1,5 +1,5 @@
 /*!
-handy-scroll v1.1.4
+handy-scroll v1.1.5
 https://amphiluke.github.io/handy-scroll/
 (c) 2024 Amphiluke
 */
@@ -194,7 +194,7 @@ https://amphiluke.github.io/handy-scroll/
             return el.removeEventListener(event, handlers[event], false);
           });
         });
-        instance.widget.parentNode.removeChild(instance.widget);
+        instance.widget.remove();
         instance.eventHandlers = instance.widget = instance.container = instance.scrollBody = null;
       }
     };

diff --git a/dist/handy-scroll.min.js b/dist/handy-scroll.min.js