This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
update precompile-xcm #161
Open
gitofdeepanshu
wants to merge
33
commits into
polkadot-v0.9.39
Choose a base branch
from
feat/setAppendix-xcm-precompile
base: polkadot-v0.9.39
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitofdeepanshu
changed the title
add SetAppendix in remote_transact
update precompile-xcm
Jun 14, 2023
Dinonard
reviewed
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR summary/message should be updated.
Dinonard
reviewed
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to discuss the XTokens inclusion and its impact on the interface with the team.
} | ||
|
||
/** | ||
* @dev Withdraw assets using PalletXCM call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't put implementation details into interface definition.
I see the old file also has this, but it's wrong.
PierreOssun
reviewed
Jul 10, 2023
Co-authored-by: PierreOssun <[email protected]>
Minimum allowed line rate is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Changes
send_xcm()
which allows to send any xcm-message to the destination chain.This addition helps in getting rid of function overloading for different Account types (AccountId32 and AccountKey20) supported by xcm.
Check list