fix(driver): use inherited joinByType method

AthennaIO · Nov 4, 2023 · b1e7e7f · b1e7e7f
1 parent 4a9e396
commit b1e7e7f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 33 deletions.
diff --git a/src/drivers/Driver.ts b/src/drivers/Driver.ts
@@ -140,6 +140,8 @@ export abstract class Driver<Client = any, QB = any> {
     }
 
     this.qb[joinType](table, column1, operation, column2)
+
+    return this
   }
 
   /**

diff --git a/src/drivers/PostgresDriver.ts b/src/drivers/PostgresDriver.ts
@@ -1221,37 +1221,4 @@ export class PostgresDriver extends Driver<Knex, Knex.QueryBuilder> {
 
     return this
   }
-
-  /**
-   * Create a join clause by join type
-   */
-  public joinByType(
-    joinType: string,
-    table: any,
-    column1?: any,
-    operation?: any,
-    column2?: any
-  ): this {
-    if (!column1) {
-      this.qb[joinType](table)
-
-      return this
-    }
-
-    if (!operation) {
-      this.qb[joinType](table, column1)
-
-      return this
-    }
-
-    if (!column2) {
-      this.qb[joinType](table, column1, operation)
-
-      return this
-    }
-
-    this.qb[joinType](table, column1, operation, column2)
-
-    return this
-  }
 }