-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust] Added clone derive for FastNoiseLite
#138
Conversation
@Keavon does this look good to you? |
Yep, this looks sensible. While we're at it, @DanielDK05 are there any other traits this ought to implement? I'm thinking probably not to |
@Keavon I also thought of unsafe impl Send for FastNoiseLite {}
unsafe impl Sync for FastNoiseLite {} But the |
Maybe let's just go with |
Yeah okay, I'll look at |
Looks good. @Auburn should this also bump the Rust crate's minor version or will you do that in a commit to master after this PR is merged? |
This was also mentioned as a potential change, don't know if we want that but should wait on it before the version if so #137 |
"It ain't much, but it's honest work"
Added a clone derive, as cloning is necessary in some cases.
N.B: the other changes in the file came from
cargo fmt