Fixing installation for node v4.2.1 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ZECTBynmo, just wandering, are you still maintaining this project? |
|
@vsukhomlinov Thanks for the pull request. I'm theoretically still maintaining the project, but I have a lot of real world stuff going on right now, so I'm doubly appreciative of the help. I'll hopefully get a chance to look over this PR this week some time and push out an npm update, but I can't promise anything. If someone else (maybe one of the creators of the issues you mentioned) comes in here and vouches for the patch, I'll accept it on faith :) |
|
I'm not one of the issue creators but I can state that it builds on my main machine and works on Node 4.2.1 on Mac OS X El Capitan. |
ZECTBynmo
added a commit
that referenced
this pull request
Nov 7, 2015
Fixing installation for node v4.2.1
|
Thanks @vsukhomlinov and @mzgoddard. Sorry for my slow progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading Nan to latest so that package can be installed on node 4.2.1(LTS)
Fixes #48, #49
Any suggestions on how to write a test that covers most of logic?