-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship/Shuttle Terminal Access Checks #20227
base: master
Are you sure you want to change the base?
Ship/Shuttle Terminal Access Checks #20227
Conversation
I am conflicted it makes sense that shuttles aren't just free for anyone to steal but at the same time, ID requirement is very harsh, especially for offships or odyssey, cause
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, there should be some way to gain access to pilot the shuttle, that isn't emag
something that the average offship or actor could do
wire hacking maybe
This seems superflous at best, the shuttle controls are already behind a door, if anything needs to be access restricted, it would be said door to access the cockpit, not the console itself? |
not always possible, majority of shuttles even on the horizon dont have this protection (windoors can be quickly smashed on canary, spark and quark can be accessed via an airlock. This has also been a major issue for offships. I believe that with the wirecutter option this doesn not impact antags too severely as they are given a variety of options to bypass this (steal ID, emag, wirecutter) |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Ben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Ship consoles such as targeting and sensors now check for access.
Emagging a ship console disables access checks
Horizon shuttles given access requirements (bridge crew can access any ship)
Went through most offships and added access requirements, likely missed some however.
For access requirements, I only added them for helm control, targetting, and shuttle control consoles