Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship/Shuttle Terminal Access Checks #20227

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Dec 1, 2024

Ship consoles such as targeting and sensors now check for access.

Emagging a ship console disables access checks

Horizon shuttles given access requirements (bridge crew can access any ship)

Went through most offships and added access requirements, likely missed some however.

For access requirements, I only added them for helm control, targetting, and shuttle control consoles

@github-actions github-actions bot added 🗺️ Mapping - Horizon The PR touches the Horizon map files. 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. labels Dec 1, 2024
@DreamySkrell
Copy link
Contributor

I am conflicted

it makes sense that shuttles aren't just free for anyone to steal

but at the same time, ID requirement is very harsh, especially for offships or odyssey, cause

  • there is no indication of what ID or access you need exactly
  • you can't gain access without having the actual ID (without emag but that's antag gear)
  • so if the pilot with access is gone then you are fucked and the shuttle will never be usable

Copy link
Contributor

@DreamySkrell DreamySkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, there should be some way to gain access to pilot the shuttle, that isn't emag
something that the average offship or actor could do
wire hacking maybe

@FluffyGhoster
Copy link
Contributor

This seems superflous at best, the shuttle controls are already behind a door, if anything needs to be access restricted, it would be said door to access the cockpit, not the console itself?

@Ben10083
Copy link
Contributor Author

Ben10083 commented Dec 4, 2024

IMO, there should be some way to gain access to pilot the shuttle, that isn't emag something that the average offship or actor could do wire hacking maybe

Added method by using wirecutters. This means that antags (or anyone else) can use wirecutters and gain access after a lengthy period
image

@Ben10083
Copy link
Contributor Author

Ben10083 commented Dec 4, 2024

This seems superflous at best, the shuttle controls are already behind a door, if anything needs to be access restricted, it would be said door to access the cockpit, not the console itself?

not always possible, majority of shuttles even on the horizon dont have this protection (windoors can be quickly smashed on canary, spark and quark can be accessed via an airlock. This has also been a major issue for offships. I believe that with the wirecutter option this doesn not impact antags too severely as they are given a variety of options to bypass this (steal ID, emag, wirecutter)

@Ben10083 Ben10083 requested a review from DreamySkrell December 4, 2024 23:23
@Ben10083
Copy link
Contributor Author

Ben10083 commented Dec 5, 2024

Now in sections of 15 instead of needing 2 minutes uninterupted. Repairable with cabling
image
image

Copy link

github-actions bot commented Dec 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@DreamySkrell DreamySkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. 🗺️ Mapping - Horizon The PR touches the Horizon map files. Review Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants