-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pybind11 support for orbetto #1
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lvb2000
commented
Nov 7, 2023
•
edited
Loading
edited
- added pybind11 library (git clone)
- added main wrapper for orbetto called orbethon (orboculum + perfetto + python)
- added python argparse wrapper for options
- added meson and ninja build to GitHub Actions
Note: The elf file could not be parsed in python as the symbol table did not have length entries for strings. That is why the whole .text section is wrapped as python list(uint8_t) and handed over to c++ main function.
Reduces computation time significantly if code is run multiple times with the same protocol information
Perfetto UI can handle prints a lot better than counts
niklaut
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Some minor polish, then squash and rebase on top of main.
remove orbetto.cpp build as it is included in orbethon
added pip install of pyelftools and cxxfilt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.