Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(php-fpm): Add support for mailpit #464

Merged
merged 2 commits into from
Apr 11, 2023
Merged

feat(php-fpm): Add support for mailpit #464

merged 2 commits into from
Apr 11, 2023

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Apr 10, 2023

No description provided.

@sjinks sjinks requested a review from a team as a code owner April 10, 2023 10:14
@sjinks sjinks self-assigned this Apr 10, 2023
pschoffer
pschoffer approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@pschoffer pschoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Are we planning to add it as a seperate container?

@pschoffer
Copy link
Contributor

Oh nevermind explined here - Automattic/vip-cli#1329

@sjinks sjinks merged commit b92f6bc into master Apr 11, 2023
@sjinks sjinks deleted the add/mailpit branch April 11, 2023 07:25
@sjinks sjinks mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pschoffer pschoffer pschoffer approved these changes

Assignees

@sjinks sjinks

Labels
[Status] Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjinks @pschoffer