Add yaml linter github action

.github/workflows/ci-go.yml

@@ -1,3 +1,4 @@
+---
 name: 'ci-go'
 on:
   pull_request:

.github/workflows/yamllint.yml

@@ -0,0 +1,23 @@
+---
+# MegaLinter GitHub Action configuration file
+# More info at https://oxsecurity.github.io/megalinter
+name: mega-linter-yaml
+
+on:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  build:
+    name: mega-linter-yaml
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
+        with:
+          fetch-depth: 1
+
+      - name: yamllint
+        uses: oxsecurity/megalinter/flavors/ci_light@v7

.golangci.yml

@@ -1,3 +1,4 @@
+---
 run:
   timeout: 10m
   skip-dirs-use-default: true
@@ -22,4 +23,4 @@ linters:
     - unused
 linters-settings:
   goimports:
-    local-prefixes: github.com/Azure/ARO-HCP
+    local-prefixes: github.com/Azure/ARO-HCP

.yaml-lint.yml

@@ -0,0 +1,30 @@
+---
+yaml-files:
+  - '*.yaml'
+  - '*.yml'
+  - '.yamllint'
+
+rules:
+  braces: enable
+  brackets: enable
+  colons: enable
+  commas: enable
+  comments: disable
+  comments-indentation: disable
+  document-end: disable
+  document-start: disable
+  empty-lines: enable
+  empty-values: disable
+  hyphens: enable
+  indentation: disable
+  key-duplicates: enable
+  key-ordering: disable
+  line-length: disable
+  new-line-at-end-of-file: enable
+  new-lines: enable
+  octal-values: disable
+  quoted-strings: disable
+  trailing-spaces: enable
+  truthy:
+    level: warning
+    check-keys: false

api/redhatopenshift/HcpCluster/hcpCluster-models.tsp

@@ -258,9 +258,6 @@ model PlatformProfile {
   /** The core outgoing configuration */
   outboundType?: OutboundType = OutboundType.loadBalancer;
 
-  /** Specifies whether subnets are pre-attached with an NSG */
-  preconfiguredNsgs: boolean;
-
   /** The id of the disk encryption set to be used for etcd.
    * Configure this when `etcdEncryption` is set to true
    * Is used the https://learn.microsoft.com/en-us/azure/storage/common/customer-managed-keys-overview

api/redhatopenshift/HcpCluster/tspconfig.yaml

@@ -1,3 +1,4 @@
+---
 emit:
   - '@azure-tools/typespec-autorest'
 options: