Skip to content

Commit

Permalink
Isolate api as a standalone component in this monorepo
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Shen <[email protected]>
  • Loading branch information
mjlshen committed Apr 19, 2024
1 parent 56d04b7 commit d4bb1a3
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 17 deletions.
3 changes: 2 additions & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"editorconfig.editorconfig",
"ms-azuretools.vscode-bicep",
"ms-vscode.azurecli",
"arjun.swagger-viewer"
"arjun.swagger-viewer",
"typespec.typespec-vscode"
],

"settings": {
Expand Down
25 changes: 15 additions & 10 deletions .github/workflows/api-lint.yml → .github/workflows/api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,39 +7,44 @@ on:
pull_request:
branches:
- main
paths:
- 'api/**'
- 'package.json'
- 'package-lock.json'

jobs:
typescript_api_spec_validation:
permissions:
contents: 'read'
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
with:
fetch-depth: 1
sparse-checkout: 'api'
sparse-checkout-cone-mode: false

- name: Setup Node.js
uses: actions/setup-node@c2ac33f2c62f978d6c944d9648125a294e56dc0b # v4.0.2
with:
node-version: 'v20.12.0'

- name: Install tsp
run: npm install -g @typespec/[email protected]

- name: Install dependencies
run: npm ci
run: npm ci

- name: Install autorest
- name: Install autorest
run: npm install -g [email protected]

- name: Compile tsp
run: tsp compile ./api/redhatopenshift/HcpCluster --warn-as-error

- name: Generate OpenAPI
run: autorest api/autorest-config.yaml

- name: make generate
run: make generate
working-directory: './api'

- name: Check for Uncommitted Changes
run: |
git diff --exit-code || (echo "::error::Uncommitted changes detected in OpenAPI spec. Please regenerate and commit them." && exit 1)
6 changes: 0 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,3 @@ deploy-frontend:

undeploy-frontend:
oc process -f ./deploy/aro-hcp-frontend.yml -p ARO_HCP_FRONTEND_IMAGE=${ARO_HCP_FRONTEND_IMAGE} | oc delete -f -

.PHONY: api
api:
tsp compile api/redhatopenshift/HcpCluster/
autorest api/autorest-config.yaml

6 changes: 6 additions & 0 deletions api/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
SHELL = /bin/bash

.PHONY: generate
generate:
tsp compile redhatopenshift/HcpCluster --warn-as-error
autorest autorest-config.yaml

0 comments on commit d4bb1a3

Please sign in to comment.