Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce step action based structs #1005

Merged
merged 6 commits into from
Dec 19, 2024
Merged

introduce step action based structs #1005

merged 6 commits into from
Dec 19, 2024

Conversation

geoberle
Copy link
Collaborator

@geoberle geoberle commented Dec 18, 2024 •
edited
Loading

What this PR does

  • added Step minimal interface for step metadata
  • introduce ShellStep and ARMStep structs for existing steps to hold action specific parameters
  • introduce new step types for DNS child zone delegation and KV issuer configuration

Jira:
Link to demo recording:

Special notes for your reviewer

janboll
janboll previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@janboll janboll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions GitHub Actions
Copy link

Please rebase pull request.

@geoberle geoberle force-pushed the issuer-registration branch from 55ed22d to 35b721b Compare December 18, 2024 14:28
@geoberle geoberle force-pushed the issuer-registration branch from 35b721b to e1c0d47 Compare December 18, 2024 14:29
@geoberle
introduce step action based structs
a686d1e 
Signed-off-by: Gerd Oberlechner <[email protected]>
@geoberle
remove parsing indirection on step level
8f7147d 
Signed-off-by: Gerd Oberlechner <[email protected]>
@geoberle
remove RG parsing magic func
90698b7 
Signed-off-by: Gerd Oberlechner <[email protected]>
@geoberle
new types
809d83b 
Signed-off-by: Gerd Oberlechner <[email protected]>
@geoberle
update testdata for configref
985e87d 
Signed-off-by: Gerd Oberlechner <[email protected]>
@geoberle
json array handling
a3a5728 
Signed-off-by: Gerd Oberlechner <[email protected]>
@geoberle geoberle force-pushed the issuer-registration branch from 8ecce5f to a3a5728 Compare December 19, 2024 09:18
@geoberle geoberle merged commit aee24b6 into main Dec 19, 2024
19 checks passed
@geoberle geoberle deleted the issuer-registration branch December 19, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@janboll janboll janboll left review comments

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@weinong weinong Awaiting requested review from weinong weinong is a code owner

@whober0521 whober0521 Awaiting requested review from whober0521 whober0521 is a code owner

@tony-schndr tony-schndr Awaiting requested review from tony-schndr tony-schndr is a code owner

@jmelis jmelis Awaiting requested review from jmelis jmelis is a code owner

@jonathan34c jonathan34c Awaiting requested review from jonathan34c jonathan34c is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geoberle @janboll @stevekuznetsov