ARO-9420: *: add acrpull controller, binding #1011
Open
+882
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
requested review from
bennerv,
geoberle,
janboll,
weinong,
whober0521,
tony-schndr,
mbarnes,
SudoBrendan,
jmelis,
jonathan34c,
UlrichSchlueter,
jharrington22 and
zgalor
as code owners
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
from
d4d4a7a to
21d7769
Compare
?? |
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
2 times, most recently
from
76b9942 to
a234856
Compare
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
from
a234856 to
a6d978d
Compare
geoberle
reviewed
Dec 20, 2024
|
|
||
| module acrPullerRoles 'acr/acr-permissions.bicep' = [ | ||
| for (_, i) in acrPullResourceGroups: { | ||
| name: guid(acrRg[i].id, aksCluster.id, acrPullRoleDefinitionId) |
There was a problem hiding this comment.
this name definition is identical with the one used in module acrPullRole - hence the error during the PR check what-if
Suggested change
| name: guid(acrRg[i].id, aksCluster.id, acrPullRoleDefinitionId) | |
| name: guid(acrRg[i].id, aksCluster.id, acrPullRoleDefinitionId, 'puller-identity') |
Comment on lines
+493
to
+497
| audiences: [ | ||
| 'api://AzureCRTokenExchange' | ||
| ] | ||
| issuer: aksCluster.properties.oidcIssuerProfile.issuerURL | ||
| subject: 'system:serviceaccount:${workloadIdentities[i].value.namespace}:${workloadIdentities[i].value.serviceAccountName}' |
There was a problem hiding this comment.
after running this template i get the error Issuer and subject combination already exists for this Managed Identity
so an MI can be federated only once with a certain SA on a cluster BUT the audience list can only hold one value.
https://learn.microsoft.com/en-us/entra/workload-id/workload-identity-federation-considerations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #986