Add Pipeline Run Script #1012
Open
Add Pipeline Run Script #1012
+203
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janboll
requested review from
bennerv,
jharrington22,
SudoBrendan,
UlrichSchlueter and
zgalor
as code owners
janboll
force-pushed
the
add-pipeline-run
branch
from
6f99df4 to
6409973
Compare
janboll
force-pushed
the
add-pipeline-run
branch
from
4d94ea6 to
54d8403
Compare
geoberle
reviewed
Dec 20, 2024
| @@ -82,7 +82,7 @@ | |||
| - name: 'Deploy Frontend' | |||
| run: | | |||
| make frontend.deploy | |||
| ./run_pipeline.sh dev ./frontend/pipeline.yaml deploy -c public | |||
There was a problem hiding this comment.
how about we change the content of the make frontend.deploy target to use run_pipeline.sh?
that way also provisioning outside of GH action uses the pipeline files
| @@ -0,0 +1,125 @@ | |||
| #!/bin/bash | |||
|
|
|||
| PROJECT_ROOT_DIR=$(dirname "$(realpath "${BASH_SOURCE[0]}")") | |||
There was a problem hiding this comment.
this is basically a copy of tempatlize.sh
can we try to pull the common parts into a script we include in both templatlize.sh and run_pipeline.sh?
There was a problem hiding this comment.
Sure can do. I somehow feared having a single script can be quite complicated, but I'll give it a shot.
There was a problem hiding this comment.
maybe pull out some things into a lib.sh script that is included
e.g. the short region name calculation
janboll
requested review from
weinong,
whober0521 and
tony-schndr
as code owners
janboll
force-pushed
the
add-pipeline-run
branch
2 times, most recently
from
6a66f7b to
19c6c34
Compare
janboll
force-pushed
the
add-pipeline-run
branch
from
19c6c34 to
95e3147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer