Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell the user what is going to happen #1013

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

jfchevrette
Copy link
Collaborator

What this PR does

Small change which adds a message before running az ... delete actions for .clean make targets

As a new user I found it unsettling to see the following when running make clean and having to blindly answer yes

# make clean
Are you sure you want to perform this operation? (y/n): y
Are you sure you want to perform this operation? (y/n): y
Are you sure you want to perform this operation? (y/n): y

With this simple change, the user knows what operation they are agreeing to

An alternate option was to remove the @ and let make output the commands, but this also outputs the if conditions and is unnecessarily verbose

Jira:
Link to demo recording:

Special notes for your reviewer

@geoberle geoberle merged commit d345e2d into main Dec 19, 2024
7 checks passed
@geoberle geoberle deleted the describe-az-clean-actions branch December 19, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants