Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting persist: true on resource groups #107

Merged
merged 1 commit into from
May 7, 2024
Merged

Allow setting persist: true on resource groups #107

merged 1 commit into from
May 7, 2024

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented May 7, 2024 •
edited
Loading

What this PR does

  • Adds a persist parameter to allow exempting resources from cleanup if desired. Defaults to false
  • Renames mc-cluster --> mgmt-cluster
  • Removes the CreatedByConfig tag that was sporadically set/not used
  • az bicep format
  • Updated docs

Jira: ARO-7327

Trying it out:

AKSCONFIG=svc-cluster make svc-cluster
AKSCONFIG=svc-cluster make clean
AKSCONFIG=mgmt-cluster make mgmt-cluster
AKSCONFIG=mgmt-cluster make clean

@mjlshen mjlshen merged commit c86e73a into Azure:main May 7, 2024
2 checks passed
@mjlshen mjlshen deleted the ARO-7327 branch May 7, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-amann s-amann s-amann approved these changes

@tonytheleg tonytheleg tonytheleg approved these changes

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjlshen @tonytheleg @s-amann