Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables creation of multiple workload identities via loop and arrays #108

Merged
merged 1 commit into from
May 8, 2024

Conversation

tonytheleg
Copy link
Collaborator

@tonytheleg tonytheleg commented May 7, 2024

What this PR does

  • defines a workload identities array for creating multiple uami's and federated credentials for use with workload identities
  • minor updates to templates to facilitate above change

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

@tonytheleg tonytheleg force-pushed the ARO-7328-dynamic-wi-creation branch from b4c72a0 to c05998b Compare May 7, 2024 18:49
@tonytheleg tonytheleg force-pushed the ARO-7328-dynamic-wi-creation branch from c05998b to a4b2cb1 Compare May 7, 2024 20:33
@tonytheleg tonytheleg marked this pull request as ready for review May 7, 2024 20:35
@mjlshen mjlshen merged commit c5afbfa into Azure:main May 8, 2024
3 checks passed
@tonytheleg tonytheleg deleted the ARO-7328-dynamic-wi-creation branch May 21, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants