Move frontend-specific make targets to frontend/Makefile #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
Frontend-specifc
make
targets were defined in/Makefile
on the repo's root dir.After this PR:
Frontend-specific
make
targets are defined in/frontend/Makefile
for better component encapsulation.This also shortens the
make
target names to:image
,deploy
,undeploy
,deploy-private
,undeploy-private
Jira:
Link to demo recording:
Special notes for your reviewer
Uses a kludge to get the full git repo into the build container, since files can't be copied from outside of Docker's build context:
Makefile: Run "git archive" from the repo's root dir, output the temporary archive file into the frontend directory
Dockerfile: Extract the archive file into the build container
Makefile: Delete the temporary archive file
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.