Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move frontend-specific make targets to frontend/Makefile #109

Merged
merged 1 commit into from
May 8, 2024

Conversation

mbarnes
Copy link
Collaborator

@mbarnes mbarnes commented May 7, 2024

What this PR does

Before this PR:

Frontend-specifc make targets were defined in /Makefile on the repo's root dir.

After this PR:

Frontend-specific make targets are defined in /frontend/Makefile for better component encapsulation.

This also shortens the make target names to: image, deploy, undeploy, deploy-private, undeploy-private

Jira:
Link to demo recording:

Special notes for your reviewer

Uses a kludge to get the full git repo into the build container, since files can't be copied from outside of Docker's build context:

  • Makefile: Run "git archive" from the repo's root dir, output the temporary archive file into the frontend directory

  • Dockerfile: Extract the archive file into the build container

  • Makefile: Delete the temporary archive file

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

Uses a kluge to get the full git repo into the build container:

- Makefile: Run "git archive" from the repo's root dir, output the
  temporary archive file into the frontend directory

- Dockerfile: Extract the archive file into the build container

- Makefile: Delete the temporary archive file
@s-amann s-amann merged commit 270da4a into Azure:main May 8, 2024
2 checks passed
@mbarnes mbarnes deleted the frontend-make-targets branch May 8, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants