New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action and make targets to validate bicep #110

Merged

mjlshen merged 1 commit into Azure:main from mjlshen:bicepfmt

May 8, 2024

Contributor

mjlshen commented May 8, 2024 •

edited

Loading

What this PR does

Adds dev-infrastructure make targets to lint/format bicep files
- Should be mostly a non-factor because, if you use the VSCode Bicep extension, these will be taken care of. Long term (in a future PR) it would be good to hook it up to a subscription to run a "what-if" or plan as well to ease PR reviews.
Adds a GitHub Action to validate bicep file lint/formatting
Moves AKSCONFIG inside make targets that require it

mjlshen requested review from bennerv, petrkotas, s-amann, UlrichSchlueter, tonytheleg and jharrington22 as code owners

May 8, 2024 13:05

mjlshen force-pushed the bicepfmt branch 4 times, most recently from 958e10e to 60e545e Compare

May 8, 2024 13:46


          Add GitHub Action and make targets to validate bicep

117a23a

Signed-off-by: Michael Shen <[email protected]>

mjlshen force-pushed the bicepfmt branch from 60e545e to 117a23a Compare

May 8, 2024 13:50

tonytheleg approved these changes

View reviewed changes

s-amann approved these changes

View reviewed changes

mjlshen merged commit 2e01baa into Azure:main

4 checks passed

mjlshen deleted the bicepfmt branch

May 8, 2024 15:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

s-amann s-amann approved these changes

tonytheleg tonytheleg approved these changes

bennerv Awaiting requested review from bennerv bennerv is a code owner

petrkotas Awaiting requested review from petrkotas

UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

Labels

None yet