Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates gitignore to fix image build and prevent false dirty #114

Merged
merged 1 commit into from
May 8, 2024

Conversation

tonytheleg
Copy link
Collaborator

What this PR does

Before this PR:
The image build process creates an archive file to facilitate the build process and then removes it
This causes the image to be tagged as dirty as there are uncommited changes due to the new file

After this PR:

  • adds the expected archive file to gitignore so that the commit is not seen as dirty when its clean
  • this ensures deploying using make target selects the correct image as both steps rely on COMMIT variable defined in makefile

Jira:
Link to demo recording:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

@mjlshen mjlshen merged commit 6e5cbb5 into Azure:main May 8, 2024
2 checks passed
@tonytheleg tonytheleg deleted the frontend-image-build-minor-fix branch May 21, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants