Allow creating both mgmt/svc cluster idempotently #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjlshen
requested review from
bennerv,
petrkotas,
s-amann,
UlrichSchlueter and
tonytheleg
as code owners
mjlshen
commented
May 8, 2024
| LOCATION?=eastus | ||
| RESOURCEGROUP=aro-hcp-${AKSCONFIG}-$(USER) | ||
| DEPLOYMENTNAME=$(RESOURCEGROUP) |
There was a problem hiding this comment.
DEPLOYMENTNAME needed to be unique between the mgmt/svc cluster
| @@ -1,5 +1,5 @@ | |||
| // Constants | |||
| param aksClusterName string = 'aro-hcp-cluster-001' | |||
| param aksClusterName string = take('aro-hcp-${clusterType}-${uniqueString(clusterType)}', 63) | |||
There was a problem hiding this comment.
This allows for a unique cluster name between mgmt/svc clusters
| @@ -125,7 +138,7 @@ resource aks_keyvault_crypto_user 'Microsoft.Authorization/roleAssignments@2022- | |||
| } | |||
| } | |||
|
|
|||
| resource vnet 'Microsoft.Network/virtualNetworks@2023-09-01' = { | |||
| resource vnet 'Microsoft.Network/virtualNetworks@2023-11-01' = { | |||
There was a problem hiding this comment.
This allows vnet/subnet to behave idempotently now from Azure/azure-quickstart-templates#2786
Comment on lines
+116
to
+127
| rotationPolicy: { | ||
| lifetimeActions: [ | ||
| { | ||
| action: { | ||
| type: 'notify' | ||
| } | ||
| trigger: { | ||
| timeBeforeExpiry: 'P30D' | ||
| } | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Default values that are being imported into the module
Signed-off-by: Michael Shen <[email protected]>
bennerv
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
make mgmt-cluster/make svc-clusterAfter this PR:
make mgmt-cluster/make svc-cluster, making iterating on changes easier.Applying the mgmt-cluster/svc-cluster targets again now results in:
Jira: ARO-6158