bicep refmt #117
Merged
bicep refmt #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formatting changed in the latest release... https://github.com/Azure/bicep/releases/tag/v0.27.1 Signed-off-by: Michael Shen <[email protected]>
mjlshen
requested review from
bennerv,
petrkotas,
s-amann,
UlrichSchlueter,
tonytheleg and
jharrington22
as code owners
bennerv
reviewed
May 9, 2024
| @@ -27,10 +27,11 @@ jobs: | |||
| - name: 'az bicep format and lint' | |||
| working-directory: './dev-infrastructure' | |||
| run: | | |||
| az bicep version | |||
There was a problem hiding this comment.
did you want to keep this?
What do you think about an az bicep upgrade here as well?
There was a problem hiding this comment.
When I was running linting against it earlier, i was getting warnings about the 2023-04-01 (or 09-01) NSG/VNET resource id until i upgraded my bicep on the azure-cli.
There was a problem hiding this comment.
I did, just for easier troubleshooting - yesterday I had az bicep upgrade and it didn't actually upgrade in the GitHub Actions runner due to a bicep.use_binary_from_path configuration.
Take a look at this attempt from yesterday https://github.com/Azure/ARO-HCP/actions/runs/9006416096/job/24743908959 in the az bicep format and lint step
Run az bicep upgrade
WARNING: The configuration value of bicep.use_binary_from_path has been set to 'false'.
Installing Bicep CLI v0.26.170...
Successfully installed Bicep CLI to "/home/runner/.azure/bin/bicep".
set -e; \
FILES="$(find . -type f -name "*.bicep*")"; \
for file in $FILES; do \
echo "az bicep format --file ${file}"; \
az bicep format --file $file; \
done
az bicep format --file ./modules/aks-cluster-base.bicep
WARNING: A new Bicep release is available: v0.27.1. Upgrade now by running "az bicep upgrade".
s-amann
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting changed in the latest release...
https://github.com/Azure/bicep/releases/tag/v0.27.1