Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @azure-tools and @typespec for dependabot #122

Merged
merged 2 commits into from
May 13, 2024

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented May 13, 2024

What this PR does

Dependabot was unable to update these dependencies correctly in #119 and #120 due to cross-dependencies between @azure-tools and @typespec. This PR updates Dependabot's configuration so that it will update these together moving forward.

Furthermore, after re-running make generate, a new deprecation message appeared:

/workspaces/ARO-HCP/api/redhatopenshift/HcpCluster/hcpCluster-models.tsp:31:6 - error deprecated: Deprecated: Please change ManagedServiceIdentity to ManagedServiceIdentityProperty.
> 31 |   ...ManagedServiceIdentity;
     |      ^^^^^^^^^^^^^^^^^^^^^^

Found 1 error.

which was addressed by this PR. A version property of the OpenAPI spec/Go client seemed to have been misgenerated/committed on accident previously as there is no backing typespec for those fields.

* ManagedServiceIdentity was deprecated and replaced with ManagedServiceIdentityProperty
* code generation was run again, removing version properties which may
  have been committed by accident

Signed-off-by: Michael Shen <[email protected]>
@s-amann s-amann merged commit a92fb2b into Azure:main May 13, 2024
6 checks passed
@mjlshen mjlshen deleted the npm-dependabot branch May 13, 2024 20:36
s-amann added a commit to s-amann/ARO-HCP that referenced this pull request May 15, 2024
mjlshen pushed a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants