Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aks-manifest bicep module fixes #123

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

geoberle
Copy link
Collaborator

@geoberle geoberle commented May 14, 2024

this PR adresses several bugs in the aks-manifest module and its usage for serviceaccount placement

  • ServiceAccount are now generated with their correct metadata.name. previously the uamiName was used instead of the serviceAccountName
  • the aks-manifest can now handle non-namespaced manifests
  • the aks-manifest deploymentjobs are now re-executed when the manifests to apply change.

What this PR does

Before this PR:

After this PR:

Jira:
Link to demo recording:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

this PR adresses the following bugs in the aks-manifest module and its
usage for serviceaccount placement

* `ServiceAccount` are now generated with their correct `metadata.name`.
  previously the `uamiName` was used instead of the `serviceAccountName`

* the aks-manifest can now handle non-namespaced manifests

* the aks-manifest deploymentjobs are now re-executed when the manifests
  to apply change.

Signed-off-by: Gerd Oberlechner <[email protected]>
@mjlshen mjlshen merged commit dd28057 into Azure:main May 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants