Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the api for merging into the azure-rest-api-specs-pr #129

Closed
wants to merge 1 commit into from

Conversation

petrkotas
Copy link
Member

What this PR does

Before this PR:
The swagger files were located in old location, that does not reflect the current state of the azure-rest-api-specs folder any more.

After this PR:
The folder structure is reflected accordingly. Moreover the readme.md files are created with the configuration for the autorest.

Jira: https://issues.redhat.com/browse/ARO-6591
Link to demo recording:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • [x ] PR: The PR description is expressive enough and will help future contributors
  • [ x] Code: Write code that humans can understand and Keep it simple
  • [ x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • [ x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • [ x] Deployment: The deployment process was considered and addressed if required
  • [ x] Testing: New code requires new unit tests.
  • [ x] Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • [x ] Customers: Is this change affecting customers? Is the release plan considered?

Copy link

Please rebase pull request.

@petrkotas petrkotas force-pushed the update-for-arm branch 12 times, most recently from 6fc89a8 to e820879 Compare May 31, 2024 07:09
@petrkotas petrkotas requested a review from tonytheleg as a code owner May 31, 2024 07:09
Copy link

github-actions bot commented Jun 6, 2024

Please rebase pull request.

@petrkotas petrkotas force-pushed the update-for-arm branch 2 times, most recently from 95cfab8 to 455b356 Compare June 11, 2024 13:06
Copy link

Please rebase pull request.

@petrkotas petrkotas force-pushed the update-for-arm branch 3 times, most recently from f5fae96 to fd681eb Compare June 25, 2024 08:16
Move swagger to subfolder and create autorest
config readme files.

The folder structure is selected to match the
structure of the azure repository.
Copy link

Please rebase pull request.

@petrkotas
Copy link
Member Author

Closing in favor of #387

@petrkotas petrkotas closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant