Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More frontend/Makefile tweaks #143

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

mbarnes
Copy link
Collaborator

@mbarnes mbarnes commented May 23, 2024

More tweaks for quality-of-life and better consistency with dev-infrastructure.

  • Rename RESOURCE_GROUP to RESOURCEGROUP to match dev-infrastructure.
  • Default RESOURCEGROUP to the same value as dev-infrastructure ("aro-hcp-${AKSCONFIG}-$(USER)").
  • Skip Docker build (and temporary archive) if Docker image already exists.
  • make push depends on make image.

Matthew Barnes added 3 commits May 23, 2024 08:34
For consistency with /dev-infrastructure/Makefile.
- image: Skip if the docker image already exists.
- push: Depends on image target.
@mbarnes mbarnes force-pushed the frontend-resourcegroup branch from ec2f633 to cce1cb2 Compare May 23, 2024 12:34
@mjlshen mjlshen merged commit 7ae72e6 into Azure:main May 23, 2024
3 checks passed
@mbarnes mbarnes deleted the frontend-resourcegroup branch May 23, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants