Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt-cluster dressup for maestro consumer #144

Merged
merged 3 commits into from
May 23, 2024
Merged

mgmt-cluster dressup for maestro consumer #144

merged 3 commits into from
May 23, 2024

Conversation

geoberle
Copy link
Collaborator

What this PR does

this MR introduces the ability to dress up an MC to run a maestro consumer that can connect to the regional maestro infrastructure.

this includes

  • the setup of eventgrid access with fine grained topic permissions for the MC
  • the setup of a client certificate in key vault for the MC
  • managed identity and CSI secret store setup to access the certificate on the MC
  • developer documentation

additionally some refactoring on the existing maestro bicep modules was conducted, to support hosting eventgrid and key vault infra in resource groups different from clusters interacting with them.

Jira:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

geoberle added 3 commits May 23, 2024 16:08
this MR introduces the ability to dress up an MC to run a maestro consumer that can connect to the regional maestro infrastructure.

this includes

* the setup of eventgrid access with fine grained topic permissions for the MC
* the setup of a client certificate in key vault for the MC
* managed identity and CSI secret store setup to access the certificate on the MC
* developer documentation

additionally some refactoring on the existing maestro bicep modules was conducted, to support hosting eventgrid and key vault infra in resource groups different from clusters interacting with them.

part of https://issues.redhat.com/browse/ARO-7244
Signed-off-by: Gerd Oberlechner <[email protected]>
@geoberle geoberle changed the title Maestro consumer mgmt-cluster dressup for maestro consumer May 23, 2024
@mjlshen mjlshen merged commit f305d90 into main May 23, 2024
5 checks passed
@mjlshen mjlshen deleted the maestro-consumer branch May 23, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants