-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds db calls for subscriptions #145
adds db calls for subscriptions #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm, non-blocking question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted an error handling bug that needs fixed, but I like this overall.
a004d99
to
89dd8d3
Compare
Throwing this in draft as there is one other bit of logic i think needs updating and want to make sure its all tested. |
89dd8d3
to
cf635aa
Compare
Updates validated as working in cluster. Latest changes re-organize the error checking to at least check for errors right after a call, but explicitly checks for the |
cf635aa
to
2e4f738
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more nits. Requested change is for the status code, the other comment is optional.
2e4f738
to
a8cfe26
Compare
Requested changes added |
Please rebase pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved once the merge conflict is resolved.
a8cfe26
to
a6fc6c4
Compare
What this PR does
Before this PR:
After this PR:
documents.go
Jira: ARO-7410
Link to demo recording:
Special notes for your reviewer
Validation of all changes available in Jira comments (LINK
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.