Make PATCH on par with PUT + regression fix #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnes
requested review from
petrkotas,
AldoFusterTurpin,
bennerv and
mjlshen
as code owners
mbarnes
force-pushed
the
handle-patch
branch
3 times, most recently
from
839b1e1 to
d9cddce
Compare
mbarnes
changed the title
|
Please rebase pull request. |
added 3 commits
May 29, 2024 10:01
- Use path segment values instead of parsing resource IDs when possible. - log.slog output functions need a complete message, not a format string. Use fmt.Sprintf.
Logic is mostly the same. The only notable difference is PATCH requests will not create a new cluster.
Side-effect of commit 0463ecb. Embedding the generated resource struct in our own resource struct caused a mismatch with the StructTagMap keys, because the embedded generated.HcpOpenShiftClusterResource field was showing up in the validateVisibility type recursion. e.g. mapKey would be "HcpOpenShiftClusterResource.properties.spec" whereas the StructTagMap just has "properties.spec" Work around by passing the embedded HcpOpenShiftClusterResource field to api.ValidateVisibility.
s-amann
approved these changes
May 29, 2024
mjlshen
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This makes PATCH requests on par with PUT (in fact I combined the PUT and PATCH handlers).
This also fixes a visibility validation regression introduced in #124. (See the commit message in the commit that fixes it for details.) I discovered this while testing PATCH requests, so I just addressed it here instead of a separate pull request.
Jira: No Jira, just circling back to a to-do from the initial frontend pass
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.