More database refactoring #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 27, 2024 14:00
Factors out all the system-defined properties for a Cosmos container item. Also uses azcore.ETag for the ETag type for compatibility with the azcosmos.ItemOptions.IfMatchEtag field.
Dropping this for a couple reasons: 1) It's used once to create an azcosmos.DatabaseClient and then never touched again. 2) It assumes we want a DefaultAzureCredential, which may end up being correct but we shouldn't build that assumption into the config struct. Instead, NewCosmosDBClient just takes an azcosmos.DatabaseClient which is created in the command-line processing code.
So middleware functions can access the DBClient more easily.
mjlshen
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
More database refactoring ahead of more important upcoming changes.
Jira: Related to ARO-9674 : Frontend needs to run with at least two replicas
Link to demo recording:
Special notes for your reviewer