tool to generate a helm chart from an ACM MCE release #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extracts and templateizes the manifests from an MCE OLM release bundle https://issues.redhat.com/browse/ARO-10315 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
requested review from
bennerv,
janboll,
weinong,
whober0521,
jharrington22,
mjlshen,
UlrichSchlueter and
zgalor
as code owners
janboll
requested changes
Oct 11, 2024
Signed-off-by: Gerd Oberlechner <[email protected]>
Signed-off-by: Gerd Oberlechner <[email protected]>
Signed-off-by: Gerd Oberlechner <[email protected]>
Signed-off-by: Gerd Oberlechner <[email protected]>
i've added some basic tests revolving around the structure of the expected YAMLs. |
janboll
requested changes
Oct 14, 2024
tooling/mcerepkg/main.go
Outdated
| // load OLM bundle manifests | ||
| img, err := crane.Load(mceOlmBundle) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Please wrap error to make debugging easier
| imageRegistryParamName = "imageRegistry" | ||
| ) | ||
|
|
||
| type Customizer func(unstructured.Unstructured) (unstructured.Unstructured, map[string]string, error) |
There was a problem hiding this comment.
Is this type enforced from outside? Why is it not using pointers? Could save some memory using i.e.:
type Customizer func(*unstructured.Unstructured) (map[string]string, error)
and update the object in the method
Signed-off-by: Gerd Oberlechner <[email protected]>
Signed-off-by: Gerd Oberlechner <[email protected]>
janboll
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
extracts and templateizes the manifests from an MCE OLM release bundle
https://issues.redhat.com/browse/ARO-10315
this is part 1 or 2 - this part introduces the base repackage tool
part 2 will use it to replace the current ACM installation (with OLM) to one with helm (without OLM)
Jira:
Link to demo recording:
Special notes for your reviewer