Frontend bug fixes around document updates #710
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2024 09:48
In the callback function for UpdateResourceDoc, we were using the wrong ResourceDocument variable which means the ARM metadata was not actually being recorded in Cosmos.
In the callback function for UpdateSubscriptionDoc, the logic was structured in such a way that the updated subscription would never be recorded in Cosmos.
mjlshen
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Spotted a couple bone-headed bugs I introduced into the frontend recently, both related to updating Cosmos documents with optimistic concurrency control.
Jira: Followup to ARO-10822 - Add concurrency controls around Cosmos DB
Link to demo recording:
Special notes for your reviewer