templatize makefile config and bicepparams #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoberle
requested review from
bennerv,
janboll,
weinong,
whober0521,
jmelis,
jonathan34c,
niontive,
nwnt,
SudoBrendan,
UlrichSchlueter,
jharrington22 and
zgalor
as code owners
geoberle
force-pushed
the
revamp
branch
10 times, most recently
from
62d3de6 to
2be0410
Compare
|
Please rebase pull request. |
janboll
requested changes
Oct 25, 2024
geoberle
force-pushed
the
revamp
branch
3 times, most recently
from
b6383d3 to
cb80d48
Compare
|
Please rebase pull request. |
geoberle
force-pushed
the
revamp
branch
2 times, most recently
from
cd54598 to
114f319
Compare
bennerv
reviewed
Oct 30, 2024
geoberle
force-pushed
the
revamp
branch
4 times, most recently
from
93d916b to
62d9204
Compare
bennerv
previously approved these changes
Oct 31, 2024
geoberle
force-pushed
the
revamp
branch
7 times, most recently
from
919f0aa to
3c58820
Compare
using the tooling/templatize tool, the entire infrastructure and service deployment is driven by the config/config.yaml file
geoberle
added a commit
that referenced
this pull request
Nov 1, 2024
follows up on #762 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
added a commit
that referenced
this pull request
Nov 1, 2024
follows up on #762 Signed-off-by: Gerd Oberlechner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
using the tooling/templatize tool, the entire infrastructure and
service deployment is driven by the config/config.yaml file
Jira: https://issues.redhat.com/browse/ARO-11582
Link to demo recording:
Special notes for your reviewer