Unify DELETE request handling for clusters and node pools #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase pull request. |
added 2 commits
October 29, 2024 16:31
Similar to MarshalResource, this method takes a resource ID and calls the appropriate Cluster Service method to request deletion of the resource.
With the DeleteResource method, the logic flow for handling DELETE requests for clusters and node pools is now identical.
mbarnes
force-pushed
the
delete-resource
branch
from
f3f0b20 to
699de65
Compare
SudoBrendan
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Our DELETE request handlers for clusters and node pools were nearly identical. With the addition of a frontend helper method
DeleteResourcewe can now unify the request handlers and eliminate a fair amount of duplicate code.Jira: none; refactoring work
Link to demo recording:
Special notes for your reviewer