Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove running cs locally from development set up guide #818

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

JameelB
Copy link
Collaborator

@JameelB JameelB commented Nov 7, 2024

What this PR does

Removes CS local Development Setup section from the development set up guide. This should be replaced with how to connect and interact with the deployed Cluster Service for creating ARO HCP cluster and node pools.

All of the documentation for the CS local dev set up has now been moved to the CS repo: https://gitlab.cee.redhat.com/service/uhc-clusters-service/-/merge_requests/8862

Jira: N/A
Link to demo recording: N/A

Special notes for your reviewer

Copy link
Collaborator

@ahitacat ahitacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM, I just have one small comment.

Thanks @JameelB to take care of this.

dev-infrastructure/docs/development-setup.md Show resolved Hide resolved
@JameelB JameelB force-pushed the docs/remove-running-cs-locally branch from f552ab3 to faaf3d2 Compare November 11, 2024 16:48
@bennerv bennerv enabled auto-merge November 12, 2024 18:28
@JameelB JameelB force-pushed the docs/remove-running-cs-locally branch from faaf3d2 to 3c2fe6f Compare November 13, 2024 10:16
@JameelB
Copy link
Collaborator Author

JameelB commented Nov 14, 2024

@bennerv I see you've enabled auto merge here, I think it needs approval before it can be merged? 🤔

@bennerv bennerv merged commit 215e2d1 into main Nov 14, 2024
6 checks passed
@bennerv bennerv deleted the docs/remove-running-cs-locally branch November 14, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants