Grant Cluster Service access to MGMT Key Vautls #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janboll
requested review from
bennerv,
geoberle,
weinong,
whober0521,
tony-schndr,
jmelis,
jonathan34c,
niontive,
nwnt,
SudoBrendan and
UlrichSchlueter
as code owners
janboll
force-pushed
the
cs-additional-permissions
branch
2 times, most recently
from
5397a2d to
3932d27
Compare
|
@miguelsorianod can you also help review this? It's related to the work around certs and secrets persist / retrieval / delete in CS for cluster provision flow |
machi1990
reviewed
Nov 21, 2024
machi1990
reviewed
Nov 21, 2024
geoberle
reviewed
Nov 21, 2024
machi1990
reviewed
Nov 21, 2024
machi1990
reviewed
Nov 21, 2024
Co-authored-by: Gerd Oberlechner <[email protected]>
janboll
force-pushed
the
cs-additional-permissions
branch
from
e2b0848 to
743f2de
Compare
geoberle
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira: https://issues.redhat.com/browse/ARO-12201
Link to demo recording:
Special notes for your reviewer