Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maestro KV refactor #875

Merged
merged 1 commit into from
Nov 22, 2024
Merged

maestro KV refactor #875

merged 1 commit into from
Nov 22, 2024

Conversation

geoberle
Copy link
Collaborator

@geoberle geoberle commented Nov 22, 2024

What this PR does

  • remove maestro KV
  • remove KV officer MI and use devops MI
  • use SVC KV for maestro server
  • use MGMT KV for maestro agent
  • restructure modules so they can run in their own scope
    • cert creation in the RG of the respective KV (SVC or MGMT)
    • eventgrid access in the regional RG
  • make MQTT client name for maestro server configurable

bonus

  • control eventgrid public network access via config parameter

Jira: https://issues.redhat.com/browse/ARO-12515
Link to demo recording:

Special notes for your reviewer

Signed-off-by: Gerd Oberlechner <[email protected]>
@@ -30,7 +30,7 @@ resource newCertwithRotationKV 'Microsoft.Resources/deploymentScripts@2023-08-01
location: location
kind: 'AzurePowerShell'
properties: {
azPowerShellVersion: '7.5.0'
azPowerShellVersion: '12.0.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a pretty large gap, does it work? 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does. i run the code a lot :)

@geoberle geoberle merged commit 6a7f476 into main Nov 22, 2024
19 checks passed
@geoberle geoberle deleted the maestro-kv branch November 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants