Chiac/svc #893
Closed
Chiac/svc #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase pull request. |
geoberle
reviewed
Nov 27, 2024
Comment on lines
+411
to
+427
|
|
||
| // // oidc | ||
|
|
||
| // module oidc '../modules/oidc/main.bicep' = { | ||
| // name: '${deployment().name}-oidc' | ||
| // params: { | ||
| // location: location | ||
| // storageAccountName: oidcStorageAccountName | ||
| // rpMsiName: clusterServiceMIName | ||
| // skuName: oidcStorageAccountSku | ||
| // aroDevopsMsiId: aroDevopsMsiId | ||
| // deploymentScriptLocation: location | ||
| // } | ||
| // dependsOn: [ | ||
| // svcCluster | ||
| // ] | ||
| // } |
There was a problem hiding this comment.
the permission issue has been fixed in main - #897
geoberle
reviewed
Nov 27, 2024
| @@ -21,7 +21,7 @@ func EV2Mapping(input config.Variables, prefix []string) (map[string]string, map | |||
| } | |||
| replaced[key] = replacement | |||
| } else { | |||
| placeholder := fmt.Sprintf("__%s__", strings.ToUpper(strings.Join(nestedKey, "_"))) | |||
| placeholder := fmt.Sprintf("__%s__", strings.Join(nestedKey, "_")) | |||
There was a problem hiding this comment.
fixed in main including the tests - #901
geoberle
reviewed
Nov 27, 2024
Comment on lines
+374
to
+391
| // resource imageSyncAcrResourceGroups 'Microsoft.Resources/resourceGroups@2023-07-01' existing = [ | ||
| // for rg in imageSyncAcrResourceGroupNames: { | ||
| // name: rg | ||
| // scope: subscription() | ||
| // } | ||
| // ] | ||
|
|
||
| // module acrPushRole '../modules/acr-permissions.bicep' = [ | ||
| // for (_, i) in imageSyncAcrResourceGroupNames: { | ||
| // name: guid(imageSyncAcrResourceGroups[i].id, resourceGroup().name, 'image-sync', 'push') | ||
| // scope: imageSyncAcrResourceGroups[i] | ||
| // params: { | ||
| // principalId: imageSyncManagedIdentityPrincipalId | ||
| // grantPushAccess: true | ||
| // acrResourceGroupid: imageSyncAcrResourceGroups[i].id | ||
| // } | ||
| // } | ||
| // ] |
There was a problem hiding this comment.
this has been removed from main #896
geoberle
reviewed
Nov 27, 2024
Comment on lines
+393
to
+410
| // resource clustersServiceAcrResourceGroups 'Microsoft.Resources/resourceGroups@2023-07-01' existing = [ | ||
| // for rg in clustersServiceAcrResourceGroupNames: { | ||
| // name: rg | ||
| // scope: subscription() | ||
| // } | ||
| // ] | ||
|
|
||
| // module acrManageTokenRole '../modules/acr-permissions.bicep' = [ | ||
| // for (_, i) in clustersServiceAcrResourceGroupNames: { | ||
| // name: guid(clustersServiceAcrResourceGroups[i].id, resourceGroup().name, 'clusters-service', 'manage-tokens') | ||
| // scope: clustersServiceAcrResourceGroups[i] | ||
| // params: { | ||
| // principalId: csManagedIdentityPrincipalId | ||
| // grantManageTokenAccess: true | ||
| // acrResourceGroupid: clustersServiceAcrResourceGroups[i].id | ||
| // } | ||
| // } | ||
| // ] |
There was a problem hiding this comment.
this code has been moved to cluster-service.bicep and will not run in MSFT INT for the time being until we have the ACR token custom role figured out - #903
geoberle
reviewed
Nov 27, 2024
| @@ -47,7 +47,7 @@ module regionalZoneDelegation '../modules/dns/zone-delegation.bicep' = { | |||
| params: { | |||
| childZoneName: regionalDNSSubdomain | |||
| childZoneNameservers: regionalZone.properties.nameServers | |||
| parentZoneName: baseDNSZoneName | |||
There was a problem hiding this comment.
hmm. this would try to delegate the regional zone into the regional zone as child zone and parent zone would be the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer