adapt ev2 bicepparam preprocessor to generate any() #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a bicepparam file is preprocessed for EV2 with scope binding placeholders, any non-string placeholders needs to be wrapped in the `any()` bicep type function since the placeholder string would not match the expected type for the respective parameter. Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
requested review from
bennerv,
janboll,
weinong,
whober0521 and
tony-schndr
as code owners
remove the PreprocessFileForEV2SystemVars, PreprocessFileForEV2ScopeBinding helper functions they are of little use now that we have the PrecompilePipelineForEV2 functions Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
force-pushed
the
pipeline-ev2-precompile-any-params
branch
from
322a844 to
f831649
Compare
whober0521
requested changes
Nov 27, 2024
Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
force-pushed
the
pipeline-ev2-precompile-any-params
branch
from
136c277 to
91cdf05
Compare
janboll
reviewed
Nov 28, 2024
janboll
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
when a bicepparam file is preprocessed for EV2 with scope binding placeholders, any non-string placeholders needs to be wrapped in the
any()bicep type function since the placeholder string would not match the expected type for the respective parameter.this PR also cleans up several unused functions in the
ev2package that have become obsolete because of pipeline preprocessing. specifically thePreprocessFileForEV2SystemVars,PreprocessFileForEV2ScopeBindinghelper functions are of little use now that we have thePrecompilePipelineForEV2functions. they are also hard to use considering the various contexts file preprocessing involves (e.g. EV2 system variables allowed or not, scope binding vs service config, bicepparam any() or not)this PR also removed the
templatizeflag for EV2 preprocessing. since we integrate templatize as a library, there is no need to expose the preprocessing on the CLI as RH will not use itJira:
Link to demo recording:
Special notes for your reviewer