Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove explicit properties enabling specific cs provisioner steps #927

Closed
wants to merge 1 commit into from
Closed

feat: remove explicit properties enabling specific cs provisioner steps #927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions dev-infrastructure/docs/development-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,12 +393,6 @@ Then register it with the Maestro Server
"subnet_resource_id": "$SUBNETRESOURCEID",
"network_security_group_resource_id":"$NSG"
},
"properties": {
"provisioner_hostedcluster_step_enabled": "true",
"provisioner_managedcluster_step_enabled": "true",
"np_provisioner_provision_enabled": "true",
"np_provisioner_deprovision_enabled": "true"
},
"version": {
"id": "openshift-v4.17.0"
}
Expand Down
2 changes: 1 addition & 1 deletion internal/ocm/mock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func NewMockClusterServiceClient() MockClusterServiceClient {
func (mcsc *MockClusterServiceClient) GetConn() *sdk.Connection { panic("GetConn not implemented") }

func (csc *MockClusterServiceClient) AddProperties(builder *cmv1.ClusterBuilder) *cmv1.ClusterBuilder {
additionalProperties := getDefaultAdditionalProperities()
additionalProperties := map[string]string{}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbarnes I also changed it here

return builder.Properties(additionalProperties)
}

Expand Down
23 changes: 1 addition & 22 deletions internal/ocm/ocm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,27 +24,6 @@ type ClusterServiceClientSpec interface {
DeleteCSNodePool(ctx context.Context, internalID InternalID) error
}

// Get the default set of properties for the Cluster Service
func getDefaultAdditionalProperities() map[string]string {
// additionalProperties should be empty in production, it is configurable for development to pin to specific
// provision shards or instruct CS to skip the full provisioning/deprovisioning flow.
additionalProperties := map[string]string{
// Enable the ARO HCP provisioner during development. For now, if not set a cluster will not progress past the
// installing state in CS.
"provisioner_hostedcluster_step_enabled": "true",
// Enable the provisioning of ACM's ManagedCluster CR associated to the ARO-HCP
// cluster during ARO-HCP Cluster provisioning. For now, if not set a cluster will not progress past the
// installing state in CS.
"provisioner_managedcluster_step_enabled": "true",

// Enable the provisioning and deprovisioning of ARO-HCP Node Pools. For now, if not set the provisioning
// and deprovisioning of day 2 ARO-HCP Node Pools will not be performed on the Management Cluster.
"np_provisioner_provision_enabled": "true",
"np_provisioner_deprovision_enabled": "true",
}
return additionalProperties
}

type ClusterServiceClient struct {
// Conn is an ocm-sdk-go connection to Cluster Service
Conn *sdk.Connection
Expand All @@ -66,7 +45,7 @@ func (csc *ClusterServiceClient) GetConn() *sdk.Connection { return csc.Conn }

// AddProperties injects the some addtional properties into the CSCluster Object.
func (csc *ClusterServiceClient) AddProperties(builder *cmv1.ClusterBuilder) *cmv1.ClusterBuilder {
additionalProperties := getDefaultAdditionalProperities()
additionalProperties := map[string]string{}
if csc.ProvisionShardID != nil {
additionalProperties["provision_shard_id"] = *csc.ProvisionShardID
}
Expand Down
Loading