api: Make PlatformProfile.networkSecurityGroupId optional #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2024 12:58
No API changes, just re-running "make generate". You may notice some of the indentation and other stylistic changes in the generated code are non-sensical but that's just the tool.
This was referenced Dec 9, 2024
bennerv
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Subject says it all. Updated
ClusterBuilderlogic and unit tests.Jira: ARO-13341 - Updates in Frontend and API to make NSG Optional
Link to demo recording:
Special notes for your reviewer
autorestversion. There's several API-related pull requests with this commit now (#950, #951, and this) because I don't know which one will merge first.