Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct APIVersion #949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mociarain
Copy link
Collaborator

I found this when doing something else but I'm a bit confused by it.

  • I found the error no kind "Template" is registered for version "v1" in scheme when deploying cluster-service to the service cluster.
  • The docs do indeed point to it being template.openshift.io/v1 not v1 ref

I'm assuming this was working for others and there's something wrong but my setup but maybe not?

@mociarain mociarain added the bug Something isn't working label Dec 9, 2024
mbarnes
mbarnes previously approved these changes Dec 9, 2024
Copy link
Collaborator

@mbarnes mbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct to me based on documentation. Might be that it happens to work currently based on some fallback behavior in Helm or OpenShift, which if true we shouldn't be relying on.

@geoberle
Copy link
Collaborator

geoberle commented Dec 9, 2024

i'm not sure why you got this error message. we are not deploying the template to the cluster as a CR, but only the rendered artifacts from it. the version of the template should not matter at all.

oc process --local -f deploy/openshift-templates/arohcp-service-template.yml -p .... | oc apply -f

can you elaborate?

@mociarain
Copy link
Collaborator Author

can you elaborate?

This error occurs when running make deploy-namespace-template and it looks like the error is coming from oc when it's trying to parse the template. Updating the API version lets me render the template and deploy the resources.

@geoberle
Copy link
Collaborator

deploy-namespace-template

ah i see. i think i've seen a discussion about this on slack. oc version related.
thanks for fixing.
LGTM

geoberle
geoberle previously approved these changes Dec 10, 2024
Copy link

Please rebase pull request.

@mociarain mociarain dismissed stale reviews from geoberle and mbarnes via 7f9c0e5 December 16, 2024 14:23
@mociarain mociarain force-pushed the mociarain/fix-template-APIVersion branch from 77a8239 to 7f9c0e5 Compare December 16, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants